[gh-265] Add the IEx addon #266
Conversation
byhbt
force-pushed
the
chore/add-default-iex-exs-file
branch
from
a45f8eb
to
43c935b
Compare
byhbt
requested review from
andyduong1920,
bterone,
hanam1ni,
junan,
longnd and
rosle
as code owners
byhbt
requested review from
Nihisil,
nvminhtue and
liamstevens111
as code owners
| string: :light_black, | ||
| boolean: :red, |
There was a problem hiding this comment.
These are the only changes that are not default, right? I think we should leave the colors to be the default as they are subjective unless there's a benefit for doing so. I do like differentiating between the colors of booleans and nil though as they are both magenta in the default colours?
There was a problem hiding this comment.
Here is the default output:
Compare with the customized output:
As you can see that the colors have improved for readability. So as a developer, you can get started with that and don't take more time in finding colors to customization.
There was a problem hiding this comment.
After discussion, it's good to keep the color as default if nothing wrong with it. I removed the override the code colors here: @liamstevens111 0d37bf5
If the developer would like to override the syntax colors, they can override it in ~/.iex.exs.
There was a problem hiding this comment.
@byhbt So if we confirmed the colours in your terminal (all the same) are not the default colours and they actually have distinct colours as previously mentioned (although bools and nil are same 😢 ) then yeah I think should be left as default IMO. 👍
| alias <%= base_module %>.Repo | ||
| <% end %> | ||
| IEx.configure( | ||
| history_size: 1000, |
There was a problem hiding this comment.
This history_size is rather large 😀 , what is the default? I couldn't find it online and it seems whatever I change this value to it doesn't really have any effect.
There was a problem hiding this comment.
Here is the default of history_size https://github.com/elixir-lang/elixir/blob/main/lib/iex/mix.exs#L19 . Yeah admitted that it's a bit larger than the default one. I will update it to just ten times larger seem enough. Updated in 960406e
There was a problem hiding this comment.
I see, you need to have history enabled first right, ie
iex --erl “-kernel shell_history enabled”
https://hexdocs.pm/iex/1.14/IEx.html#module-shell-history
I guess if this was enabled above I could just press up to scroll back my history instead of typing v(n) to go back, right?
There was a problem hiding this comment.
yes, we need to enable it on the system as a whole.
export ERL_AFLAGS="-kernel shell_history enabled"
There was a problem hiding this comment.
Just small comment about history otherwise good to go
I see, you need to have history enabled first right, ie
iex --erl “-kernel shell_history enabled”https://hexdocs.pm/iex/1.14/IEx.html#module-shell-historyI guess if this was enabled above I could just press
upto scroll back my history instead of typingv(n)to go back, right?
Closes #265
What happened 👀
IExaddon to generate the default.iex.exsadd the project root directoryelixir_lsto the generated.gitignoreRFC templatein the Issue section. From now on, to propose a new RFC, we will use GitHub Discussion instead.Insight 📝
The
WebApp.Repois only loaded for the web project.Proof Of Work 📹
The tests should pass.