Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync codeowners with slack @guild-elixir guild #326

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Sync codeowners with slack @guild-elixir guild #326

wants to merge 1 commit into from

Conversation

Nihisil
Copy link
Contributor

@Nihisil Nihisil commented Jun 29, 2023 •
edited by olivierobert
Loading

What happened 👀

Update the CODEOWNERS file.

Insight 📝

To ensure we have enough code reviewers, it is best to add everyone in 💯

Proof Of Work 📹

the file is valid

image

@Nihisil Nihisil requested a review from a team as a code owner June 29, 2023 04:39
@Nihisil Nihisil self-assigned this Jun 29, 2023
@Nihisil
Copy link
Contributor Author

Nihisil commented Jun 30, 2023

For failing CI I have added the ticket to fix: #327

olivierobert
olivierobert approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@olivierobert olivierobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the PR description to ensure it follows the standard template. Even for small PRs, let's not skip the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierobert olivierobert olivierobert approved these changes

@byhbt byhbt byhbt approved these changes

@suho suho suho approved these changes

Assignees

@Nihisil Nihisil

Labels
type : chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nihisil @olivierobert @byhbt @suho