Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RxSwift and its libraries for UIKit variant #515

Closed
suho opened this issue Aug 24, 2023 · 0 comments · Fixed by #525
Closed

Remove RxSwift and its libraries for UIKit variant #515

suho opened this issue Aug 24, 2023 · 0 comments · Fixed by #525
Assignees
@nkhanh44
Labels
type : chore
Milestone
4.9.0

Comments

@suho
Copy link
Member

suho commented Aug 24, 2023

Why

We currently supports iOS 14 as the minimum version, so it's better to remove RxSwift and its libraries (e.g., RxAlamofire, RxNimble, etc.) out of the templates.

Who Benefits?

iOS developers
@nkhanh44 nkhanh44 self-assigned this Sep 19, 2023
nkhanh44 added a commit that referenced this issue Sep 29, 2023
@nkhanh44
[#515] Remove all Rx things
9985e09
@nkhanh44 nkhanh44 mentioned this issue Sep 29, 2023
Merged
nkhanh44 added a commit that referenced this issue Sep 29, 2023
@nkhanh44
[#515] Remove all Rx things
3dcd29b
@nkhanh44 nkhanh44 linked a pull request Sep 29, 2023 that will close this issue
[#515] Remove all Rx things #525
Merged
nkhanh44 added a commit that referenced this issue Oct 2, 2023
@nkhanh44
[#515] Add asyn await to network layer
670ef6b
nkhanh44 added a commit that referenced this issue Oct 5, 2023
@nkhanh44
[#515] Remove all Rx things
07ea0ff
nkhanh44 added a commit that referenced this issue Oct 5, 2023
@nkhanh44
[#515] Add asyn await to network layer
78dafeb
nkhanh44 added a commit that referenced this issue Oct 5, 2023
@nkhanh44
[#515] Refactor NetworkAPIProtocol
1f226eb
nkhanh44 added a commit that referenced this issue Oct 5, 2023
@nkhanh44
[#515] Refactor NetworkAPIProtocol and move them to shared folder
034edae
@blyscuit blyscuit added this to the 4.9.0 milestone Oct 5, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 5, 2023
@blyscuit
Merge pull request #525 from nimblehq/chore/#515-remove-rxswift-and-i…
94b3a23 
…ts-libs

[#515] Remove all Rx things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkhanh44 nkhanh44

Labels
type : chore
Projects
None yet
Milestone
4.9.0
Development

Successfully merging a pull request may close this issue.

[#515] Remove all Rx things nimblehq/ios-templates
3 participants
@blyscuit @suho @nkhanh44