[#494] Migrate make.sh to Swift command #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyscuit
force-pushed
the
chore/494-make-sh-swift-command
branch
9 times, most recently
from
00d257d
to
7650872
Compare
blyscuit
changed the title
blyscuit
force-pushed
the
chore/494-make-sh-swift-command
branch
2 times, most recently
from
14bbb59
to
77e08a0
Compare
blyscuit
changed the base branch from
develop
to
chore/491-migrate-set-up-firebase-test-swift-command
luongvo
reviewed
Jul 21, 2023
Scripts/Swift/SetUpiOSProject.swift
Outdated
Comment on lines
88
to
100
| print("=> 🔎 Replacing package and package name within files...") | ||
|
|
||
| try fileManager.replaceAllOccurrences(of: CONSTANT_BUNDLE_STAGING, to: bundleIdStaging) | ||
| try fileManager.replaceAllOccurrences(of: CONSTANT_BUNDLE_PRODUCTION, to: bundleIdProduction) | ||
| try fileManager.replaceAllOccurrences(of: CONSTANT_PROJECT_NAME, to: projectNameNoSpace) | ||
| try fileManager.replaceAllOccurrences(of: CONSTANT_MINIMUM_VERSION, to: minimumVersion) | ||
| print("✅ Completed") |
There was a problem hiding this comment.
Regarding the project info replacement, such as project name, package, app id, etc., we might consider using a Mustache template implementation in Swift https://github.com/groue/GRMustache.swift to reduce the boilerplate code and even make the core template to be more flexible with extra mustache supported rules 🤔
Just my suggestion for the next steps, not in this PR @nimblehq/ios-chapter. This is what we're doing in Flutter 😛
There was a problem hiding this comment.
@luongvo What do you use to generate folders and replace in files? The GRMustache.swift seems to only generate text based on the template.
There was a problem hiding this comment.
blyscuit
force-pushed
the
chore/494-make-sh-swift-command
branch
5 times, most recently
from
caf74b2
to
7e77550
Compare
blyscuit
force-pushed
the
chore/491-migrate-set-up-firebase-test-swift-command
branch
from
67030aa
to
27a283c
Compare
blyscuit
force-pushed
the
chore/494-make-sh-swift-command
branch
from
7e77550
to
ad686eb
Compare
blyscuit
requested review from
nmint8m,
phongvhd93,
vnntsu,
ducbm051291,
Shayokh144,
Thieurom and
nkhanh44
as code owners
blyscuit
force-pushed
the
chore/494-make-sh-swift-command
branch
from
ad686eb
to
38eb870
Compare
blyscuit
force-pushed
the
chore/494-make-sh-swift-command
branch
from
38eb870
to
20759d8
Compare
Base automatically changed from
chore/491-migrate-set-up-firebase-test-swift-command
to
develop
August 9, 2023 03:41
suho
approved these changes
Aug 10, 2023
Thieurom
approved these changes
Aug 11, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ducbm051291
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make.shto Swift command #494What happened 👀
Migrate make.sh to Swift Command Line
Insight 📝
make.shfor running the project with minimal change to command. Will be removed in Package all Swift Commands #495copyandcreateDirectoryinFileManager.~=matcher toString.SetUpCICDServiceto struct to be called bySetUpIOSProject.SetUpDeliveryConstantsto struct to be called bySetUpIOSProject.SetUpInterfaceto struct to be called bySetUpIOSProject.SetUpIOSProject.swiftwhich will replacemake.shProof Of Work 📹
Projects build successfully and CICD test works.