Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#552] Correct logic for choosing the CICD service #553

Closed

Conversation

nkhanh44
Copy link
Contributor

What happened 👀

  • Update the code in SetupCICD to fix the issue
  • I added a description for choosing a runner of the GitHub service.

Insight 📝

  • N/a

Proof Of Work 📹

Screenshot 2023-12-29 at 17 29 43 Screenshot 2023-12-29 at 16 55 15

"later": .later
]

if let matchedCase = mappings[name] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use guard here 🙏

]

let name = name.lowercased()
if let matchedCase = mappings[name] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here 🙏

@@ -63,10 +73,12 @@ struct SetUpCICDService {
fileManager.createDirectory(path: ".github/workflows")
switch runnerType {
case .macOSLatest:
print("Configured to run on the latest macOS.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove print

fileManager.moveFiles(in: ".github/project_workflows", to: ".github/workflows")
fileManager.removeItems(in: ".github/project_workflows")
fileManager.removeItems(in: ".github/self_hosted_project_workflows")
case .selfHosted:
print("Configured to run on self-hosted.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove print

@nkhanh44 nkhanh44 closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants