Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ./bin/dev.sh script in favor of the makefile #410

Closed
malparty opened this issue Jun 2, 2023 · 0 comments · Fixed by #443
Closed

Remove the ./bin/dev.sh script in favor of the makefile #410

malparty opened this issue Jun 2, 2023 · 0 comments · Fixed by #443
Assignees
@mosharaf13
Labels
type : feature

Comments

@malparty
Copy link
Member

malparty commented Jun 2, 2023

Why

Currently, the make dev command is more complex than it should be:
make dev calling ./bin/dev.sh calling foreman start -f Procfile.dev calling rails s 🥵

Let's remove ./bin/dev.sh and bring foreman start -f Procfile.dev directly in the make file 🚀

Who Benefits?

Dev when looking for what commands must run behind the hood.
@malparty malparty mentioned this issue Jun 2, 2023
Merged
mosharaf13 added a commit that referenced this issue Jul 11, 2023
@mosharaf13
[#410] Remove bin/dev.sh and start foreman from makefile
7bcb7b9
@mosharaf13 mosharaf13 mentioned this issue Jul 11, 2023
Merged
mosharaf13 added a commit that referenced this issue Jul 11, 2023
@mosharaf13
[#410] Remove test related to bin/dev file existence
317f2e1
mosharaf13 added a commit that referenced this issue Jul 11, 2023
@mosharaf13
[#410] Remove instructions about copying bin/dev
5cf54e5
mosharaf13 added a commit that referenced this issue Jul 12, 2023
@mosharaf13
[#410] Rename phrase add-on spec's template file
6945e3b
github-merge-queue bot pushed a commit that referenced this issue Jul 13, 2023
@mosharaf13
Remove the ./bin/dev.sh script in favor of the makefile (#443)
7f0c393 
* [#410] Remove bin/dev.sh and start foreman from makefile

* [#410] Remove test related to bin/dev file existence

* [#410] Remove instructions about copying bin/dev

* [#410] Rename phrase add-on spec's template file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mosharaf13 mosharaf13

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the ./bin/dev.sh script in favor of the makefile nimblehq/rails-templates
3 participants
@olivierobert @mosharaf13 @malparty