Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#393] Update the Bootstrap vendor file #439

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

andyduong1920
Copy link
Member

close #393

What happened 👀

Update the Bootstrap vendor file on Bootstrap 5.3

Insight 📝

This is follow the guide on the Bootstrap 5.3 with some modifier, we already used this in our projects without any error.

Proof Of Work 📹

On the file changes tab

@andyduong1920 andyduong1920 changed the title [#393] Update the Bootstrap vendor fiel [#393] Update the Bootstrap vendor file Jul 7, 2023
@andyduong1920 andyduong1920 self-assigned this Jul 7, 2023
@malparty
Copy link
Member

malparty commented Jul 7, 2023

@andyduong1920 did you try it on a project with custom variables? 👀
If not, I will plan some time next week to test that format in a real project 💭

@andyduong1920
Copy link
Member Author

@andyduong1920 did you try it on a project with custom variables? 👀 If not, I will plan some time next week to test that format in a real project 💭

@malparty I'm not sure about the custom variable topic hehe

@malparty
Copy link
Member

Ok, let me plan a small test (tomorrow after lunch 🙇 ) just to ensure it's all good in "complex" situations ^^

Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Fl app, I just got an issue with the variable used by Choice, but this is not a blocker at all. So everything else looks good!

@malparty malparty merged commit 704ae5e into develop Jul 11, 2023
5 checks passed
@malparty malparty deleted the feature/393-update-bootstrap-file branch July 11, 2023 08:29
@malparty malparty added this to the 5.7.0 milestone Jul 26, 2023
@malparty malparty mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import bootstrap SCSS functions before variables in order to benefit from scss functions
4 participants