Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#422] Change to use @nimblehq/eslint-config-nimble-core #507

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

sanG-github
Copy link
Contributor

@sanG-github sanG-github commented Mar 14, 2024

What happened 👀

As we have separated the previous version of eslint-config-nimble into many child packages with the main one being eslint-config-nimble-core, and we don't need eslint rules for react, or typescript.

Therefore, we change to use the @nimblehq/eslint-config-nimble-core package.

Insight 📝

Warning

Published a new version for the core package, but I forgot to remove the parser which hasn't been defined in the corresponding package.json -> Needs one more update before using it.

Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc » @nimblehq/eslint-config-nimble-core » /home/runner/work/rails-templates/rails-templates/rails_templates/node_modules/@nimblehq/eslint-config-nimble-core/lib/rules/import.js': Cannot find module '@typescript-eslint/parser'

After updating the version of the core package, there was a warning about the outdated usage of .eslintignore, then we switched to using the config file instead.

image

Proof Of Work 📹

image

@sanG-github sanG-github self-assigned this Mar 14, 2024
@malparty malparty added this to the 5.14.0 milestone Mar 14, 2024
@sanG-github sanG-github marked this pull request as ready for review April 9, 2024 08:51
@sanG-github sanG-github requested a review from a user April 9, 2024 08:51
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🥳

@malparty malparty added this pull request to the merge queue Apr 11, 2024
Merged via the queue into develop with commit cbf999c Apr 11, 2024
5 checks passed
@malparty malparty deleted the feature/gh422-user-eslint-config-nimble-core branch April 11, 2024 07:36
@malparty malparty mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to use @nimblehq/eslint-config-nimble-core
3 participants