Add support for old safe send link format #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how this happened, but this PR now includes unrelated Portuguese translations. Can you maybe rebase this on top of |
mariofriz
force-pushed
the
feat/add-safe-link-support
branch
from
31cd283
to
a9a5b55
Compare
Indeed something weird happened I had a strange error while rebasing, I ended up skipping the problematic commit. I rebased onto master now and also changed to named regex groups so it's a bit easier to read. |
|
@sisou Hi, I know you are busy with Nimiq 2.0 but if you get a quick chance to review this PR that would be great! If changes are needed, please let me know. |
sisou
force-pushed
the
feat/add-safe-link-support
branch
from
a9a5b55
to
de9dd3d
Compare
sisou
force-pushed
the
feat/add-safe-link-support
branch
from
13f5796
to
b4267eb
Compare
|
Thank you very much @mariofriz! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24
Changes:
Tasks: