SDL2 resource destructors segfaults fix #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Sounds good. Will merge when I can. :-) |
Serneum
pushed a commit
to Serneum/esdl2
that referenced
this pull request
Aug 30, 2016
This is from ninenines#12
Serneum
pushed a commit
to Serneum/esdl2
that referenced
this pull request
Aug 30, 2016
This is from ninenines#12
Serneum
pushed a commit
to Serneum/esdl2
that referenced
this pull request
Sep 13, 2016
This is from ninenines#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for random segfaults in SDL destructors. Discussed in issue #2.
SDL_DestroyXXXX and SDL_FreeSurface should be called from the main thread due to the lack of multithreading support in SDL2.
Probably not the cleanest or more elegant implementation to merge, but in the worst case, useful as proof of concept solving these segfaults.