Add support for multiline closures-ish #14
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really sure what to call them though. Closes #13
|
Hi @karllindmark, I don't have access to my computer right now but I'll let you know as soon as I get to the office tomorrow. Thanks! |
|
Hi @karllindmark! I just tested it and it seems I still have the same issue, did you test it against the file that I sent you ? Thanks! |
|
Man, that's embarassing. I knew there was something I had missed. 🤦🏼♂️ I'm on it! Sorry 'bout the mental hickup. @matthiasthomas |
|
Hey @matthiasthomas - I've not forgotten about you, but I've been a bit busy with other things. Not completely sure how to make this work completely, but I'm onto something. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really sure what to call them though. :-)
Closes #13 when done.
Could you guys take a look and let me know if you feel it gives the representation one would expect? @apetesh @matthiasthomas
Thanks!