Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing import #382

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix missing import #382

merged 1 commit into from
Mar 11, 2022

Conversation

seletz
Copy link
Contributor

@seletz seletz commented Mar 11, 2022

This PR fixes a missing import in the commands/script.py file.

Fixes #381

@seletz
Fix missing import
d80bf00 
This PR fixes a missing import in the `commands/script.py` file.

Fixes ninia#381
seletz added a commit to seletz/jep that referenced this pull request Mar 11, 2022
@seletz
Fix export syntax on generated jep script
af96aa1 
This PR fixes shell syntax of the generated `jep` binary.

Shell does not like blanks around the "=".  Also, it seems appropriate
to quote the path in case of paths with blanks.

Fixes ninia#383.
See also ninia#382.
seletz added a commit to seletz/jep that referenced this pull request Mar 11, 2022
@seletz
Fix export syntax on generated jep script
07d9530 
This PR fixes shell syntax of the generated `jep` binary.

Shell does not like blanks around the "=".  Also, it seems appropriate
to quote the path in case of paths with blanks.

Fixes ninia#383.
See also ninia#382.
@seletz seletz mentioned this pull request Mar 11, 2022
Merged
@seletz
Copy link
Contributor Author

seletz commented Mar 11, 2022

See also #383

@ndjensen ndjensen changed the base branch from master to dev_4.0 March 11, 2022 19:21
@ndjensen ndjensen merged commit ba3abe9 into ninia:dev_4.0 Mar 11, 2022
ndjensen pushed a commit that referenced this pull request Mar 11, 2022
@seletz
Fix export syntax on generated jep script (#384)
1239672 
This PR fixes shell syntax of the generated `jep` binary.

Shell does not like blanks around the "=".  Also, it seems appropriate
to quote the path in case of paths with blanks.

Fixes #383.
See also #382.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndjensen ndjensen ndjensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails on OSX with python3.7: missing import in jet/commands/scripts.py
2 participants
@seletz @ndjensen