Make most pyjtypes into heap types. #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings jep closer to the Python Stable ABI and ensures the pyjtypes with c extensions behave the same as the dynamically created types generated for other classes. See: https://docs.python.org/3.10/c-api/typeobj.html#static-types
|
Thanks to @Techcable who provided a starting point for this work. This is not as extensive as the work in #308 but it is a step in that direction. |
ndjensen
approved these changes
May 6, 2022
|
Great work! This should also make it easier to support alternative implementations like PyPy and GraalPython. Also the stable ABI has been gradually improving over the last couple of versions. I am hopeful #308 would go a lot better in the future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings jep closer to the Python Stable ABI and ensures the
pyjtypes with c extensions behave the same as the dynamically
created types generated for other classes.
See: https://docs.python.org/3.10/c-api/typeobj.html#static-types