-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Revert addition of tox #232
Conversation
aebe6d6
to
e01b9bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
===========================================
+ Coverage 53.35% 63.83% +10.48%
===========================================
Files 17 17
Lines 849 849
Branches 143 143
===========================================
+ Hits 453 542 +89
+ Misses 369 267 -102
- Partials 27 40 +13 ☔ View full report in Codecov by Sentry. |
e01b9bb
to
2cba903
Compare
I'm increasing the threshold for the failing test. At this point, it is clear:
I'm afraid we might be hitting the nitransforms bug cc/ @effigies. |
The nitransforms bug was related to adding per volume transforms to a chain. Should be fixed in the latest release. Are you able to fix this issue by pinning <24? |
That was about to be my next commit :D This is where I think we are hitting game over: eddymotion/test/test_integration.py Lines 44 to 55 in 4a6cf72
|
It is nitransforms. |
Let's see whether the failing test comes from the tox insulation of the environment.