Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Revert addition of tox #232

Merged
merged 3 commits into from
Oct 1, 2024
Merged

MAINT: Revert addition of tox #232

merged 3 commits into from
Oct 1, 2024

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Oct 1, 2024

Let's see whether the failing test comes from the tox insulation of the environment.

@oesteban oesteban force-pushed the fix/revert-tox branch 2 times, most recently from aebe6d6 to e01b9bb Compare October 1, 2024 10:48
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (4a6cf72) to head (2cba903).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #232       +/-   ##
===========================================
+ Coverage   53.35%   63.83%   +10.48%     
===========================================
  Files          17       17               
  Lines         849      849               
  Branches      143      143               
===========================================
+ Hits          453      542       +89     
+ Misses        369      267      -102     
- Partials       27       40       +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oesteban
Copy link
Member Author

oesteban commented Oct 1, 2024

I'm increasing the threshold for the failing test. At this point, it is clear:

  • It's not ANTs (tested with 2.3 and 2.5)
  • It's not the environment or tox (it works locally but doesn't on GHA)

I'm afraid we might be hitting the nitransforms bug cc/ @effigies.

@effigies
Copy link
Member

effigies commented Oct 1, 2024

The nitransforms bug was related to adding per volume transforms to a chain. Should be fixed in the latest release. Are you able to fix this issue by pinning <24?

@oesteban
Copy link
Member Author

oesteban commented Oct 1, 2024

Are you able to fix this issue by pinning <24?

That was about to be my next commit :D

This is where I think we are hitting game over:

xfms = nt.linear.LinearTransformsMapping(
[
nb.affines.from_matvec(nb.eulerangles.euler2mat(x=0.03, z=0.005), (0.8, 0.2, 0.2)),
nb.affines.from_matvec(nb.eulerangles.euler2mat(x=0.02, z=0.005), (0.8, 0.2, 0.2)),
nb.affines.from_matvec(nb.eulerangles.euler2mat(x=0.02, z=0.02), (0.4, 0.2, 0.2)),
nb.affines.from_matvec(nb.eulerangles.euler2mat(x=-0.02, z=0.02), (0.4, 0.2, 0.2)),
nb.affines.from_matvec(nb.eulerangles.euler2mat(x=-0.02, z=0.002), (0.0, 0.2, 0.2)),
nb.affines.from_matvec(nb.eulerangles.euler2mat(y=-0.02, z=0.002), (0.0, 0.2, 0.2)),
nb.affines.from_matvec(nb.eulerangles.euler2mat(y=-0.01, z=0.002), (0.0, 0.4, 0.2)),
],
reference=b0nii,
)

@oesteban
Copy link
Member Author

oesteban commented Oct 1, 2024

It is nitransforms.

@oesteban oesteban merged commit f3a3f03 into main Oct 1, 2024
7 checks passed
@oesteban oesteban deleted the fix/revert-tox branch October 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants