ENH: Add integration test with data for EddyMotionEstimator using the trivial b0 model #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sebastientourbier! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-07 18:27:49 UTC |
dPys
reviewed
Dec 7, 2021
eddymotion/tests/test_integration.py
Outdated
| reference=fixed_b0_img | ||
| ) | ||
| assert np.all( | ||
| abs(xfm.map(xfm.reference.ndcoords.T) - xfm2.map(xfm.reference.ndcoords.T)) < 0.4 |
There was a problem hiding this comment.
Where is 0.4 coming from out of curiosity? I'm guessing this is just unique to this test-data case?
dPys
approved these changes
Dec 7, 2021
oesteban
force-pushed
the
enh-test-integration-b0-model
branch
from
6c01f59
to
cba93d8
Compare
…y `test_proximity_estimator_trivial_model`
…ator_trivial_model`
oesteban
force-pushed
the
enh-test-integration-b0-model
branch
from
58b03ab
to
a9e67cc
Compare
mathdugre
pushed a commit
to mathdugre/eddymotion
that referenced
this pull request
Jun 24, 2022
…tion-b0-model ENH: Add integration test with data for EddyMotionEstimator using the trivial b0 model
mathdugre
pushed a commit
to mathdugre/eddymotion
that referenced
this pull request
Jun 24, 2022
…tion-b0-model ENH: Add integration test with data for EddyMotionEstimator using the trivial b0 model
oesteban
added a commit
that referenced
this pull request
Jun 30, 2022
…-model ENH: Add integration test with data for EddyMotionEstimator using the trivial b0 model Former-commit-id: 8de089f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40, this PR includes the following:
A notebook in
docs/notebooksthat I created to reproduce all the steps required for the creation of the data used in the integration. All details for the generation can be found there.A set of files for the integration test:
b0.moving.nii.gz: 4D volume where the first 3D volume is the original b0, followed by 10 b0 volumes transformed with the motion parameters estimated from the last 10 frames of the fMRI recordinggradients.moving.tsv: Fake RAS+B gradient table for the 10 moving b0 volumesb0.moving.transforms.npy: A Numpy array of size (4x4x10) that stores the transforms estimated from fMRIA new function
test_proximity_estimator_trivial_model()that uses the set of files and checks the proximity of the transforms estimated byEddyMotionEstimatorwith a trivial B0 model.