Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small patch for the rebasing of the main directory under src #75

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

GalKepler
Copy link
Contributor

Just a small fix - updated the location of the ._version.py written by setup_scm. Fixes #63

@arokem
Copy link
Collaborator

arokem commented Jun 24, 2022

Test data now lives here: https://zenodo.org/record/6721110#.YrXPyRPMLKp

src/eddymotion/_version.py Outdated Show resolved Hide resolved
@arokem
Copy link
Collaborator

arokem commented Jun 24, 2022

The tests on this branch are still pretty hopelessly broken. I tried to work towards fixing them in GalKepler#3, but there are still failures I don't understand. I would need @oesteban to explain to me how the logo implementation works before I can make progress. In particular, how does the model fit method know that only some of the data is provided as training data (e.g., on this line) and to account for that fact when selecting which volumes conform with b0 requirements that are set (for example) on this line?

.gitignore Outdated Show resolved Hide resolved
@oesteban
Copy link
Member

@arokem It seems we should work on the documentation actually - if you can't wrap your head around how it works then I'm pretty positive that literally any other outsider will fall into that trap. I'm opening #76 for this.

@oesteban oesteban merged commit 30d9b5d into nipreps:main Jun 29, 2022
@oesteban
Copy link
Member

oesteban commented Jul 1, 2022

Check out #84. In particular, there was a bug using the gradient table of the full dataset instead of that of the training subsample (i.e., N - 1).

@arokem
Copy link
Collaborator

arokem commented Jul 1, 2022

Thanks! That helps! See questions on #84 for followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructuring this package to fit newer python packaging standard
3 participants