Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: restore cifti medial wall masking, subcortical volume LAS reorientation #298

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

madisoth
Copy link
Contributor

Restores medial wall masking of CIFTI surface BOLD timeseries (originally part of #212 ) and reorientation of CIFTI subcortical BOLD timeseries to LAS (#229 ); both fixes were unintentionally reverted when #278 was merged.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.24 🎉

Comparison is base (df80894) 30.55% compared to head (0cb3621) 31.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   30.55%   31.80%   +1.24%     
==========================================
  Files          53       52       -1     
  Lines        4765     4858      +93     
==========================================
+ Hits         1456     1545      +89     
- Misses       3309     3313       +4     
Impacted Files Coverage Δ
nibabies/workflows/bold/resampling.py 10.34% <0.00%> (ø)

... and 104 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madisoth madisoth changed the title FIX: restore cifti medial wall masking, subctx LAS orientation FIX: restore cifti medial wall masking, subctx LAS reorientation Jun 15, 2023
@madisoth madisoth changed the title FIX: restore cifti medial wall masking, subctx LAS reorientation FIX: restore cifti medial wall masking, subcortical volume LAS reorientation Jun 15, 2023
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we should really prioritize #215

@mgxd mgxd merged commit d649e3d into nipreps:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants