Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement run+? which would make increment within that sequence #701

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

request by @dnkennedy

TODOs

  • make sure does not break existing
  • add tests for +? mode

@dnkennedy
Copy link

Is there something I should do regarding testing this?

@yarikoptic yarikoptic added the minor Increment the minor version when merged label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01% ⚠️

Comparison is base (69c271e) 82.00% compared to head (e2223bb) 82.00%.

❗ Current head e2223bb differs from pull request most recent head 38a80b5. Consider uploading reports for the commit 38a80b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   82.00%   82.00%   -0.01%     
==========================================
  Files          41       41              
  Lines        4130     4139       +9     
==========================================
+ Hits         3387     3394       +7     
- Misses        743      745       +2     
Files Changed Coverage Δ
heudiconv/heuristics/reproin.py 84.68% <75.00%> (-0.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants