Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: many fixes for _scans.tsv files #73

Merged
merged 7 commits into from
Aug 24, 2017
Merged

BF: many fixes for _scans.tsv files #73

merged 7 commits into from
Aug 24, 2017

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Aug 11, 2017

  • assign metadata also to the ones under sessions
  • n/a for empty values (as the bible says)
  • correct time stamps per file
  • having -ses_ suffix where applicable (BIDS manuscript also was fixed, validator works correctly)
  • sanitize more fields in .json files (just in case)

@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #73 into master will increase coverage by 0.16%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   78.26%   78.43%   +0.16%     
==========================================
  Files           6        6              
  Lines        1109     1127      +18     
==========================================
+ Hits          868      884      +16     
- Misses        241      243       +2
Impacted Files Coverage Δ
tests/test_main.py 100% <100%> (ø) ⬆️
bin/heudiconv 74.06% <92.59%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bd423...cf17d76. Read the comment docs.

@yarikoptic
Copy link
Member Author

any feedback or a merge would be very welcome @satra? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants