Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Schedule int64 warning to convert to error at 5.0 #1173

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 3, 2023

Follow-up to #1082, which will need to transition from a warning to an error on the release of 5.0 (which I'm aiming for next week).

Created a new function in nibabel.deprecated to turn what we need to do here into a template that can be used elsewhere.

@effigies effigies added this to the 5.0.0 milestone Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 92.37% // Head: 92.37% // No change to project coverage 👍

Coverage data is based on head (e662e55) compared to base (e662e55).
Patch has no changes to coverable lines.

❗ Current head e662e55 differs from pull request most recent head 0aeecbc. Consider uploading reports for the commit 0aeecbc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1173   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files          97       97           
  Lines       12243    12243           
  Branches     2524     2524           
=======================================
  Hits        11310    11310           
  Misses        613      613           
  Partials      320      320           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member Author

effigies commented Jan 3, 2023

@matthew-brett Any opinions?

@effigies
Copy link
Member Author

effigies commented Jan 6, 2023

This just needs to happen. I'm going to merge...

@effigies effigies merged commit 02c7a34 into nipy:master Jan 6, 2023
@effigies effigies deleted the mnt/int64_error branch January 6, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant