Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Bump minimum numpy to 1.13 #868

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 27, 2020

As of January 16, the next minor release (3.1) is to require numpy 1.13.

TODO:

  • Check for any code that branches on numpy < 1.13
  • Titrate a minimum packaging while we're at it.

Ref #803.

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #868 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   89.66%   89.67%   +<.01%     
==========================================
  Files          96       96              
  Lines       12378    12378              
  Branches     2184     2184              
==========================================
+ Hits        11099    11100       +1     
  Misses        933      933              
+ Partials      346      345       -1
Impacted Files Coverage Δ
nibabel/volumeutils.py 84.13% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6863271...d388bed. Read the comment docs.

@effigies
Copy link
Member Author

Looks like we can use any version of packaging. That's simple.

@effigies effigies merged commit 95c934b into nipy:master Jan 28, 2020
@effigies effigies deleted the nep29/numpy_1_13 branch January 28, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant