Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skull_file output to fsl.BET interface #3095

Merged
merged 4 commits into from
Nov 16, 2019
Merged

Conversation

stilley2
Copy link
Contributor

Summary

Adds a missing output to fsl.BET.

The skull parameter tells BET to output a skull image. However, there was no corresponding output parameter for that image. This PR adds it.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member

Can you make specs?

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #3095 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3095      +/-   ##
==========================================
- Coverage   67.86%   67.86%   -0.01%     
==========================================
  Files         295      295              
  Lines       39260    39263       +3     
  Branches     5171     5172       +1     
==========================================
+ Hits        26644    26646       +2     
- Misses      11911    11912       +1     
  Partials      705      705
Flag Coverage Δ
#smoketests 51.23% <66.66%> (ø) ⬆️
#unittests 65.09% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/preprocess.py 81.65% <66.66%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a86999...7f85f43. Read the comment docs.

@effigies
Copy link
Member

Hi @stilley2, sorry to do this to you, but we just merged some pretty huge changes. Could you re-apply these changes on the latest master? You'll want to re-run make specs entirely, and we're now using the Black formatter. You can run it manually, or use pre-commit to have it automatically run every time you commit.

Please let me know if you need any help or clarifications.

@effigies effigies changed the title add skull_file output Add skull_file output to fsl.BET interface Nov 16, 2019
@effigies effigies merged commit 53eff64 into nipy:master Nov 16, 2019
@effigies effigies added this to the 1.4.0 milestone Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants