Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contrast outputs for EstimatedModel #3577

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

manuegrx
Copy link
Contributor

@manuegrx manuegrx commented Jun 8, 2023

If factorial design is used for fMRI model specification (parameter "factor_info" in Level1design), spm automatically creates contrasts (con*, ess*, spmF* and spmT* images) during model estimation (EstimateModel).

Those outputs are not yet in EstimateModel in Nipype, the aim of this PR is to add them.

Issue : #3576

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.02 ⚠️

Comparison is base (68a7cd4) 63.19% compared to head (1467f1c) 63.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
- Coverage   63.19%   63.18%   -0.02%     
==========================================
  Files         308      308              
  Lines       40792    40808      +16     
  Branches     5489     5653     +164     
==========================================
+ Hits        25779    25783       +4     
- Misses      14000    14012      +12     
  Partials     1013     1013              
Impacted Files Coverage Δ
nipype/interfaces/spm/model.py 42.25% <25.00%> (-0.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Please note that nipype is not very actively maintained and does not have a specific release schedule, and you may find it easier to maintain your own interfaces in the packages that need them.

If you are interested in helping with the maintenance, let us know.

@manuegrx
Copy link
Contributor Author

manuegrx commented Jul 6, 2023

Thank you very much !

@manuegrx manuegrx deleted the bugfix_spm_model branch July 6, 2023 06:59
@effigies effigies mentioned this pull request Mar 20, 2024
6 tasks
@effigies effigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants