-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs with fsl_out=True
and lta_out=True
#3583
Conversation
…rguments with 'fsl_file' and 'lta_file' respectively
Co-authored-by: Chris Markiewicz <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3583 +/- ##
==========================================
- Coverage 63.19% 63.19% -0.01%
==========================================
Files 308 308
Lines 40790 40792 +2
Branches 5487 5489 +2
==========================================
+ Hits 25778 25779 +1
+ Misses 14009 14000 -9
- Partials 1003 1013 +10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and thanks for your patience. The test failures are unrelated.
Summary
Fixes #3582 .
The options 'fsl_out' and 'lta_out'in TKregister2 should check and add arguments with 'fsl_file' and 'lta_file' respectively. Otherwise, a key error would be raised when setting
fsl_out=True
orlta_out=True
List of changes proposed in this PR (pull-request)
Tkregister2._format_arg
so thatfsl_out=True
andlta_out=True
options use the correct name for the argument and finding the argument value