Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with fsl_out=True and lta_out=True #3583

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Conversation

jadecci
Copy link
Contributor

@jadecci jadecci commented Jun 26, 2023

Summary

Fixes #3582 .

The options 'fsl_out' and 'lta_out'in TKregister2 should check and add arguments with 'fsl_file' and 'lta_file' respectively. Otherwise, a key error would be raised when setting fsl_out=True or lta_out=True

List of changes proposed in this PR (pull-request)

  • Fix Tkregister2._format_arg so that fsl_out=True and lta_out=True options use the correct name for the argument and finding the argument value
  • Add contribution

jadecci and others added 2 commits June 26, 2023 15:35
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (68a7cd4) 63.19% compared to head (46554ac) 63.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3583      +/-   ##
==========================================
- Coverage   63.19%   63.19%   -0.01%     
==========================================
  Files         308      308              
  Lines       40790    40792       +2     
  Branches     5487     5489       +2     
==========================================
+ Hits        25778    25779       +1     
+ Misses      14009    14000       -9     
- Partials     1003     1013      +10     
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/utils.py 60.48% <0.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.zenodo.json Outdated Show resolved Hide resolved
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and thanks for your patience. The test failures are unrelated.

@effigies effigies merged commit b4cc4db into nipy:master Jul 5, 2023
@effigies effigies mentioned this pull request Mar 20, 2024
6 tasks
@effigies effigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsl_out=True does not work for freesurfer.TKregister2
2 participants