Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: DWIPreproc issue #3596

Merged
merged 5 commits into from
Jul 31, 2023
Merged

FIX: DWIPreproc issue #3596

merged 5 commits into from
Jul 31, 2023

Conversation

GalKepler
Copy link
Contributor

Summary

Just a small fix in MRtrix3's DWIPreproc class - referencing out_grad_mrtrix instead of export_grad_mrtrix in the _list_outputs method of the class.

Fixes #3595.

List of changes proposed in this PR (pull-request)

  • Fixed DWIPreproc class.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca27e51) 63.17% compared to head (7420058) 63.17%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3596   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files         308      308           
  Lines       40813    40813           
  Branches     5654     5654           
=======================================
  Hits        25784    25784           
  Misses      14016    14016           
  Partials     1013     1013           
Files Changed Coverage Δ
nipype/interfaces/mrtrix3/preprocess.py 79.86% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

Looks good. Thanks!

@GalKepler
Copy link
Contributor Author

Sure. Just noticed that export_grad_fsl is also referenced instead of out_grad_fsl. Fixed it.

@effigies effigies merged commit 2ffd002 into nipy:master Jul 31, 2023
17 checks passed
GalKepler pushed a commit to GalKepler/nipype that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Mrtrix3's DWIPreproc
2 participants