Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @djarecka, this one is still in progress (I have errors when running the test, described below), but open this PR to keep tracking notes.
eddy
has some fancy functions e.g., running on GPUs, see here, the currenteddy
doesn't have it. I guess we need to have some customized functions if we want this cuda part?FileNotFoundError: [Errno 2] No such file or directory: 'eddy_openmp'
everything before the breakpoint was fine.we can discuss it tomorrow.