Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert eddy & adding test data #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yibeichan
Copy link
Collaborator

Hi @djarecka, this one is still in progress (I have errors when running the test, described below), but open this PR to keep tracking notes.

  • It seems that eddy has some fancy functions e.g., running on GPUs, see here, the current eddy doesn't have it. I guess we need to have some customized functions if we want this cuda part?
  • my test failed at this line with the error FileNotFoundError: [Errno 2] No such file or directory: 'eddy_openmp' everything before the breakpoint was fine.
    we can discuss it tomorrow.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1e40613) 0.30% compared to head (f46d827) 0.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #48      +/-   ##
=========================================
- Coverage    0.30%   0.29%   -0.01%     
=========================================
  Files          33      34       +1     
  Lines         660     671      +11     
  Branches       96      96              
=========================================
  Hits            2       2              
- Misses        658     669      +11     
Impacted Files Coverage Δ
pydra/tasks/fsl/epi/eddy.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yibeichan
Copy link
Collaborator Author

we have an issue open for this #50

@yibeichan
Copy link
Collaborator Author

yibeichan commented May 17, 2023

@djarecka just a note, I tried Datalad, but still can't push it.
so what I did was,

  • datalad clone xxxx; I had to create a new branch convert-eddy-2, I couldn't check out the current convert-eddy branch due to the large file (pydra/tasks/fsl/tests/data/cope_merged.nii.gz (25M)); set this branch upstream to origin
  • on this new branch, made the edits, datalad save -m "xxx"
  • then datalad push where datalad didn't give me errors but an empty action summary.
  • after this empty push, datalad status returned nothing to save, working tree clean. no history commit was found.
  • no any record on my github repo remotely

maybe I miss something when using datalad, or I can try to fix the large file (pydra/tasks/fsl/tests/data/cope_merged.nii.gz (25M)) first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants