Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Require cloudpickle >= 2.0 #517

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Mar 29, 2022

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Closes #457.

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #517 (07566cc) into master (13dc5ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files          20       20           
  Lines        4326     4326           
  Branches     1211     1211           
=======================================
  Hits         3413     3413           
  Misses        721      721           
  Partials      192      192           
Flag Coverage Δ
unittests 78.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13dc5ea...07566cc. Read the comment docs.

@djarecka djarecka merged commit bf8d6e8 into nipype:master Mar 31, 2022
@effigies effigies deleted the mnt/cloudpickle2 branch March 31, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FunctionTask hashes depending on imports
2 participants