Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datalad task #594

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add datalad task #594

wants to merge 23 commits into from

Conversation

yibeichan
Copy link
Collaborator

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

as discussed with @djarecka, add datalad interface (adopted from mriqc) to pydra task

Checklist

  • I have added tests to cover my changes
    but the test didn't pass locally, got an error TypeError: __init__() missing 1 required positional argument: 'func'; will discuss with Dorota through meeting
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 81.16% // Head: 80.87% // Decreases project coverage by -0.28% ⚠️

Coverage data is based on head (5d5a154) compared to base (c2cc452).
Patch coverage: 64.61% of modified lines in pull request are covered.

❗ Current head 5d5a154 differs from pull request most recent head edac2c8. Consider uploading reports for the commit edac2c8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   81.16%   80.87%   -0.29%     
==========================================
  Files          20       21       +1     
  Lines        4391     4456      +65     
  Branches     1262        0    -1262     
==========================================
+ Hits         3564     3604      +40     
- Misses        823      852      +29     
+ Partials        4        0       -4     
Flag Coverage Δ
unittests 80.87% <64.61%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/tasks/datalad.py 64.61% <64.61%> (ø)
pydra/engine/task.py 93.23% <0.00%> (-0.31%) ⬇️
pydra/engine/core.py 92.96% <0.00%> (-0.16%) ⬇️
pydra/engine/helpers.py 86.05% <0.00%> (ø)
pydra/engine/workers.py 18.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants