Add tests for --error
and --output
as sbatch_args
in test_submitter
#638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Added tests for valid
--error
and--output
assbatch_args
.Checklist
I am getting error for
test_slurm_args_3
while testing (which checks for--error
) -AttributeError: 'NoneType' object has no attribute 'replace'
Possible reason for this could be in workers.py here. In this, we are assigning
error_file
toNone
when--error
flag is indeed detected. And later we are using.replace()
function onerror_file
which isNone
in our case.