NDEV-20176 : backport allow changes for preexisting resources that violate policy #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late policy Signed-off-by: Ved Ratan <[email protected]>
Signed-off-by: Ved Ratan <[email protected]>
Signed-off-by: Ved Ratan <[email protected]>
|
@VedRatan can you also add the kuttl test (translate them from chainsaw) |
|
@VedRatan the lint and unit test workflow is failing. Can you look at that as well please! |
| @@ -33,6 +34,7 @@ func (h mutateExistingHandler) Process( | |||
| resource unstructured.Unstructured, | |||
| rule kyvernov1.Rule, | |||
| contextLoader engineapi.EngineContextLoader, | |||
| exceptions []*v2alpha1.PolicyException, | |||
There was a problem hiding this comment.
exception changes are unrelated to the PR
Signed-off-by: Ved Ratan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR backports the upstream fix, that allows the mutation of the resources which violates the policies.
Related issue
JIRA
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments