Add initial Pie Chart implementation #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinmurali
approved these changes
Jan 10, 2024
pygsheets/worksheet.py
Outdated
| @@ -1676,6 +1677,19 @@ def add_chart(self, domain, ranges, title=None, chart_type=ChartType.COLUMN, anc | |||
| """ | |||
| return Chart(self, domain, ranges, chart_type, title, anchor_cell) | |||
|
|
|||
| def add_pie_chart(self, domain, chart_range, title=None, anchor_cell=None, three_dimensional=False, pie_hole=0): | |||
| """ | |||
| Similar to `add_cart`, but created a Pie Chart instead of a Basic Chart. | |||
There was a problem hiding this comment.
typo: add_cart should be add_chart
Sounds good, just pushed fixes! |
|
Awesome! thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a Pie Chart to a Sheet I was populating using pygsheets. I added an initial implementation here that extends the
Chartclass with a few key changes. Definitely a little bit of duplicated/similar code in the methods that get overridden in thePieChartclass - open to suggestions if you want a deeper re-write to abstract some of that out. Hopefully this can also help build a pattern for other future "non-basic" Charts to get support.