Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-native should not always add the default user to the docker group #101

Closed
SuperSandro2000 opened this issue Jun 8, 2022 · 0 comments · Fixed by #105
Closed

docker-native should not always add the default user to the docker group #101

SuperSandro2000 opened this issue Jun 8, 2022 · 0 comments · Fixed by #105
Labels
enhancement New feature or request

Comments

@SuperSandro2000
Copy link
Member

Adding a user to the docker group basically gives the user root rights withou a password. The option at https://github.com/nix-community/NixOS-WSL/blob/main/modules/docker-native.nix#L26-L28 should at least be made configurable.
@SuperSandro2000 SuperSandro2000 added the enhancement New feature or request label Jun 8, 2022
SuperSandro2000 added a commit to SuperSandro2000/NixOS-WSL that referenced this issue Jun 10, 2022
@SuperSandro2000
Don't add the default user to docker group by default
7ee2b82 
Closes nix-community#101
@SuperSandro2000 SuperSandro2000 mentioned this issue Jun 10, 2022
Merged
@nzbr nzbr closed this as completed in #105 Jun 15, 2022
nzbr pushed a commit that referenced this issue Jun 15, 2022
@SuperSandro2000
Don't add the default user to docker group by default (#105)
d820aad 
* Don't add the default user to docker group by default

Closes #101

* Make default depend on security.sudo.wheelNeedsPassword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't add the default user to docker group by default SuperSandro2000/NixOS-WSL
1 participant
@SuperSandro2000