Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI Tests #161

Merged
merged 35 commits into from
Nov 25, 2022
Merged

Add CI Tests #161

merged 35 commits into from
Nov 25, 2022

Conversation

nzbr
Copy link
Member

@nzbr nzbr commented Nov 10, 2022 •
edited
Loading

TODO:

  • write readme
  • make tests run with actual WSL
  • docker-native works
  • Systemd-User works
  • Different user shells work

@nzbr nzbr added the enhancement New feature or request label Nov 10, 2022
@nzbr nzbr force-pushed the tests branch 2 times, most recently from cf7a237 to f890f36 Compare November 10, 2022 07:47
@nzbr nzbr force-pushed the tests branch 2 times, most recently from 8b44d65 to 9ffedc9 Compare November 10, 2022 08:02
@nzbr nzbr force-pushed the tests branch 2 times, most recently from d76a862 to fdf3af3 Compare November 10, 2022 08:17
@nzbr nzbr force-pushed the tests branch 2 times, most recently from 025b55c to 237271a Compare November 17, 2022 22:15
@nzbr nzbr marked this pull request as ready for review November 25, 2022 08:24
@nzbr nzbr merged commit bab9aa4 into nix-community:main Nov 25, 2022
@nzbr nzbr deleted the tests branch November 25, 2022 18:17
SuperSandro2000
SuperSandro2000 reviewed Nov 25, 2022
View reviewed changes
scripts/syschdemd.nix
Comment on lines +34 to 35
"${gnugrep}/bin" # grep
"${systemd}/lib/systemd" # systemd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use lib.makeBinPath here

@SuperSandro2000
Copy link
Member

Thanks for this. If I notice anything I'll let you know. Maybe I remember to run the tests on one of my WSL machines to see if they universally work and are not just WOMMM.

@nzbr nzbr added tests Anything related to checks or tests and removed enhancement New feature or request labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
tests Anything related to checks or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzbr @SuperSandro2000