fix: mount propagation (and also oomd) #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ew ew ew ew ew ew
K900
requested review from
SuperSandro2000 and
nzbr
and removed request for
SuperSandro2000
|
The /dev/shm dance is lifted from https://github.com/arkane-systems/bottle-imp/blob/master/binsrc/imp-executor/__main__.py#L28 |
Comment on lines
+180
to
+181
| # this option doesn't exist on older NixOS, so hack. | ||
| (lib.optionalAttrs (builtins.hasAttr "oomd" options.systemd) { |
There was a problem hiding this comment.
Maybe we should just lift the minimal supported version to 22.11
There was a problem hiding this comment.
That is probably better done in a separate PR.
There was a problem hiding this comment.
That's not really dropping support for 22.05 though.
nzbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ugh.