fix: default user name isn't necessarily the same as user attr name #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
approved these changes
Jan 27, 2023
|
@KoviRobi I have opened a PR against yours that adds tests for this KoviRobi#2 |
Add tests for changing username and diverging user attr and name
|
I am actually doing the same so I am surprised that it works for me and not for you. |
| @@ -153,7 +156,7 @@ with lib; { | |||
| }) | |||
| (mkIf cfg.nativeSystemd { | |||
| wsl.wslConf = { | |||
| user.default = cfg.defaultUser; | |||
| user.default = config.users.users.${cfg.defaultUser}.name; | |||
There was a problem hiding this comment.
ah, probably because my user.users attr matches name.
There was a problem hiding this comment.
Changing the username has always worked fine, but having different username and attr hasn't
SuperSandro2000
approved these changes
Jan 29, 2023
nzbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me with my weird system again, sorry.