Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable udev by default (it can be useful when using usbip)" #232

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Revert "Enable udev by default (it can be useful when using usbip)" #232

merged 2 commits into from
Mar 17, 2023

Conversation

SuperSandro2000
Copy link
Member

Reverts #225

Going to revert this because it draws in firmware which is 300MB big and cannot easily be disabled.

@KoviRobi
Copy link
Contributor

Totally fair, I wonder what I did wrong when I compared sizes in the tarball

@nzbr
Copy link
Member

nzbr commented Mar 16, 2023

We could do

  hardware.firmware = mkOverride 60 [ ];

but I guess usbip will need the firmware files

@SuperSandro2000
Copy link
Member Author

Also reversing that is in question much harder than just reenabling udev.

@SuperSandro2000 SuperSandro2000 merged commit d151883 into main Mar 17, 2023
@SuperSandro2000 SuperSandro2000 deleted the revert-225-patch-1 branch March 17, 2023 00:41
@nzbr nzbr added the release-exclude Excluded from release changelog label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-exclude Excluded from release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperSandro2000 @KoviRobi @nzbr