Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release preparation #295

Merged
merged 15 commits into from
Sep 29, 2023
Merged

New release preparation #295

merged 15 commits into from
Sep 29, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented Sep 29, 2023

This should hopefully unblock us, finally.

Flake lock file updates:

• Updated input 'flake-utils':
    'github:numtide/flake-utils/f9e7cf818399d17d347f847525c5a5a8032e4e44' (2023-08-23)
  → 'github:numtide/flake-utils/ff7b65b44d01cf9ba6a71320833626af21126384' (2023-09-12)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/4f77ea639305f1de0a14d9d41eef83313360638c' (2023-09-07)
  → 'github:NixOS/nixpkgs/5cfafa12d57374f48bcc36fda3274ada276cf69e' (2023-09-27)
This is not used in dependency resolution, yet, but will be eventually.
@github-actions github-actions bot added the tests Anything related to checks or tests label Sep 29, 2023
@K900 K900 force-pushed the prep-release branch 5 times, most recently from 1af018a to ff54d2c Compare September 29, 2023 18:15
@nzbr
Copy link
Member

nzbr commented Sep 29, 2023

Why does it create a shell script instead of a tarball? Can't we just run whatever that script does inside a derivation?

@K900
Copy link
Contributor Author

K900 commented Sep 29, 2023

No, we need to run the script as root and not in the sandbox so we can do chroot stuff.

@K900 K900 force-pushed the prep-release branch 2 times, most recently from c973622 to ffc7a4f Compare September 29, 2023 18:27
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this in depth but big thanks for tackling this.

modules/interop.nix Show resolved Hide resolved
@K900 K900 force-pushed the prep-release branch 2 times, most recently from 363688c to bd73ba8 Compare September 29, 2023 18:52
Quoth man mount(2)

> EINVAL
>
> A bind operation (MS_BIND) was requested where source
> referred a mount namespace magic link (i.e., a
> /proc/pid/ns/mnt magic link or a bind mount to such a
> link) and the propagation type of the parent mount of
> target was MS_SHARED, but propagation of the requested
> bind mount could lead to a circular dependency that might
> prevent the mount namespace from ever being freed.
Copy link
Member

@nzbr nzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested the builder locally (with nix run github:...) and it seems to work flawless

@nzbr nzbr added enhancement New feature or request and removed tests Anything related to checks or tests labels Sep 29, 2023
@nzbr nzbr merged commit 8735bdf into main Sep 29, 2023
19 checks passed
@nzbr nzbr deleted the prep-release branch September 29, 2023 21:25
@terlar
Copy link
Contributor

terlar commented Sep 30, 2023

Thank you for a lot of fixes and finally having installer-free environment. It is a bit unfortunate that one have to use sudo/root, but I guess that is the case if chroot is needed...

One regression I discovered is the inability to configure the stuff that ends up in /etc/nixos/.... Having the ability to place custom code there allows for packing a tarball with much nicer experience.

Now the out of the box experience is:

       error: file 'nixos-wsl/modules' was not found in the Nix search path (add it using $NIX_PATH or -I)

       at «none»:0: (source not available)

[user@wsl:~]$ sudo nixos-rebuild -I nixos-config=/etc/nixos/configuration.nix switch

I find it nice for the user to be able to iterate on a base and so in my own packaging of the tarball I bundled at flake that pulls in the appropriate nixos-wsl module etc.

Where should such config live? I can make a PR to re-introduce this feature.

@K900
Copy link
Contributor Author

K900 commented Sep 30, 2023

That error isn't about custom code, it's just about channels not being included in the tarball. We can probably run nix-channel --update at tarball build time. As for custom config, maybe we should just have an option for adding arbitrary files to the tarball...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants