-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back customizing the system config to include in the tarball #304
Bring back customizing the system config to include in the tarball #304
Conversation
Generally, I'd probably prefer to have a more generic mechanism of just adding arbitrary files, similar to what |
71a9d01
to
472620c
Compare
I updated according to your comments. That might be a good idea, but I'm not entirely sure how you would like that implemented. I don't personally see any value in combining custom configuration with the default configuration. As soon as you add your own custom configuration via Perhaps the current |
It's not necessarily about custom configuration - it's about adding arbitrary files in general, like secrets or SSH keys or whatever. |
You mean generally in the tarball filesystem? Or specifically inside /etc/nixos (what this is mainly about). I guess there is also a case of being able to configure arbitrary commands being executed in the script. Having a configuration to add steps and their actions. I guess for example if you are planning to use flakes the part of channels is unnecessary. But I think that is a bigger topic. |
I mean in the tarball in general, see |
This was previously implemented in nix-community#260, but lost in the migration off the installer tarball.
472620c
to
9cb8ca8
Compare
I'll merge this as-is and make a new issue to add something like |
This was previously implemented in #260, but lost in the migration off the installer tarball.