Add a workaround to support VS Code's Remote WSL extension (fix #238) #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
changed the title
Atry
changed the title
Atry
changed the title
|
I would prefer to see something like https://github.com/K900/vscode-remote-workaround, which simply uses nixpkgs node.js |
|
This PR is technically not a workaround. It just provides what vscode-server assumes (global C runtime and global coreutils). |
|
Then neither is my approach, because it provides a functioning Node runtime. |
|
But it replaces vscode’s node on fly, right?
…On Tue, Nov 7, 2023 at 7:29 PM K900 ***@***.***> wrote:
Then neither is my approach, because it provides a functioning Node
runtime.
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAES3OVQE52LJSADH3D26ELYDL4CRAVCNFSM6AAAAAA634FOO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQHE2TIMZXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Correct. |
SuperSandro2000
requested changes
Nov 9, 2023
| description = "Workaround for VSCode's Remote WSL extension"; | ||
| }; | ||
| nix-ld-rs = lib.mkOption { | ||
| type = lib.types.raw; |
There was a problem hiding this comment.
This should be type package.
|
Since you are reluctant to accept this PR. I just put it in a separate repository and close this PR. Feel free to use this module from https://github.com/Atry/nixos-wsl-vscode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
modules/vscode-remote-wsl-extension-workaround.nix, whenwsl.vscodeRemoteWslExtensionWorkaround.enableistrue, VS Code's Remote WSL extension can connect to NixOS, fixing #238See https://github.com/Atry/nixos-wsl-vscode/blob/main/flake.nix for usage