fix: tarball builder #341
Merged
fix: tarball builder #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terlar
force-pushed
the
fix-tarball-builder
branch
from
5c8f603
to
3df1967
Compare
| @@ -56,7 +56,7 @@ in | |||
|
|
|||
| root=$(mktemp -p "''${TMPDIR:-/tmp}" -d nixos-wsl-tarball.XXXXXXXXXX) | |||
| # FIXME: fails in CI for some reason, but we don't really care because it's CI | |||
| trap 'rm -rf "$root" || true' INT TERM EXIT | |||
| trap 'chattr -Rf -i "$root" || true && rm -rf "$root" || true' INT TERM EXIT | |||
There was a problem hiding this comment.
I don't think this is doing what you thought it would do
Suggested change
| trap 'chattr -Rf -i "$root" || true && rm -rf "$root" || true' INT TERM EXIT | |
| trap 'chattr -Rf -i "$root"; rm -rf "$root"; true' INT TERM EXIT |
we probably want something like the above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tarball builder when trying to remove
/var/emptyand environments whereHOMEvariable is set.See #337 and #338