Add shell-wrapper to inject env variables into non-login shells #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wrapper around every user shell so that we can make sure that the environment gets set.
bashdoes not source/etc/bashrcwhen running non-interactively, thereby breaking things likewsl -d nixos <some command>(unless the full path to the command is specified of course). This is not a problem for other distros, because Microsoft's/initbinary adds some common locations to thePATHbefore starting the shell, but we don't have those here.As a welcome side-effect, this also fixes #399
(I didn't notice that this was a problem until I tried to fix the Windows tests, because zsh doesn't have this problem. It just always sources its config files)