Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building tarballs that do not contain the system config #80

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

nzbr
Copy link
Member

@nzbr nzbr commented Apr 16, 2022

This adds the wsl.tarball.includeConfig option, that allows the user to disable including the system config, when building a custom tarball

Closes #61

@nzbr nzbr added the enhancement New feature or request label Apr 16, 2022
@nzbr nzbr requested a review from grantbevis April 16, 2022 23:36
@grantbevis
Copy link

I'm away currently @nzbr and unable to test. Have you tested yourself? I'll try do a code review but it's not the easiest from my phone 😂

Copy link

@grantbevis grantbevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as approved, all looks ok to me bud but I am unable to test as per my other comment.

mkdir -p ./etc/nixos/nixos-wsl
cp -R ${lib.cleanSource ../.}/. ./etc/nixos/nixos-wsl
mv ./etc/nixos/nixos-wsl/configuration.nix ./etc/nixos/configuration.nix
# Patch the import path to avoid havin a flake.nix in /etc/nixos

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having*

@nzbr nzbr merged commit f0dd180 into nix-community:main Apr 17, 2022
@nzbr nzbr deleted the optional-config branch April 17, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow building tarballs that do not contain the system config
2 participants