Make the webhook endpoint URL configurable #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some CI setups, the URL to access the CI server differs from the URL that the (external) webhook endpoint listens on. This change introduces an option webhookBaseUrl that allows setting that URL independently from the buildbot installation URL.
antifuchs
force-pushed
the
separate-webhook-url
branch
from
d28c4b0
to
bc81bfd
Compare
Mic92
reviewed
May 8, 2024
|
Out of interest, does setting the webhook url manually change the need for the user to be an admin in gitea? Or do you still set the url automatically, just with this revised url. |
|
You still have to have permissions to set the webhook endpoint on each repo. This only alters the URL that the buildbot-nix code sets using those permissions. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2f38900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some CI setups (especially those where the CI server is reachable over a VPN with split-horizon DNS), the URL to access the CI server differs from the URL that the (external) webhook endpoint listens on.
This change introduces an option webhookBaseUrl that allows setting that URL independently from the buildbot installation URL.