Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded ghc version. #257

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Remove hardcoded ghc version. #257

merged 4 commits into from
Sep 20, 2022

Conversation

bezmuth
Copy link
Contributor

@bezmuth bezmuth commented Aug 18, 2022

This removes the hardcoded ghc version (8107) and instead uses one specified in the settings for stack-lock or auto detected for cabal-plan.

In reference to #177 some more work still needs to be done to flesh out the hidden package dynamic generation but I think this is a step in the right direction.

@DavHau
Copy link
Member

DavHau commented Aug 23, 2022

I think it would be beneficial if we store the compiler version as version parts separated via . or -. This would allow us to differentiate between major and bugfix version. We could allow the user to ignore the compiler bugfix version for example, which would increase the likelyhood of finding a matching compiler in nixpkgs.

@bezmuth
Copy link
Contributor Author

bezmuth commented Aug 24, 2022

I think it would be beneficial if we store the compiler version as version parts separated via . or -. This would allow us to differentiate between major and bugfix version. We could allow the user to ignore the compiler bugfix version for example, which would increase the likelyhood of finding a matching compiler in nixpkgs.

I chose to store the compiler versions using just numbers to match how they are formatted in nixpkgs, could you give an example of how you want the version numbers to be formatted?

@DavHau
Copy link
Member

DavHau commented Aug 25, 2022

I chose to store the compiler versions using just numbers to match how they are formatted in nixpkgs, could you give an example of how you want the version numbers to be formatted?

How about storing it like this:

{
  compiler = {
    name = "ghc";
    version = "8.10.7";
  };
}

@DavHau DavHau merged commit bf2e8dd into nix-community:main Sep 20, 2022
@DavHau
Copy link
Member

DavHau commented Sep 20, 2022

Thanks for that

@DavHau DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer-of-nix Issues/PRs opened by SoN participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants