-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded ghc version. #257
Conversation
I think it would be beneficial if we store the compiler version as version parts separated via |
I chose to store the compiler versions using just numbers to match how they are formatted in nixpkgs, could you give an example of how you want the version numbers to be formatted? |
How about storing it like this: {
compiler = {
name = "ghc";
version = "8.10.7";
};
} |
Co-authored-by: Brian Leung <[email protected]>
Thanks for that |
This removes the hardcoded ghc version (8107) and instead uses one specified in the settings for stack-lock or auto detected for cabal-plan.
In reference to #177 some more work still needs to be done to flesh out the hidden package dynamic generation but I think this is a step in the right direction.