Minor cleanup #311

tinybeachthor · 2022-09-30T19:10:34Z

After #300

Set version in `composer.json` to the package version, composer is conservative and will fail if there the package version is not set and any dependency version conflicts are declared.

Without composer.json in the root of a package, composer will ignore the dependency, this is issue if for example npm dependencies are managed via composer. (yiisoft/yii2 2.0.46)

package name and composer.json#name can be different (mostly happens in private repositories) set the composer.json#name to the package name before including the package in other one

no network access in the pure builder, patches will have to be handled as overrides probably

when composer is installing from source it ignores git submodules, do the same

@tinybeachthor

It looks like `rootName` should be set to the *parent* name, but currently points at the name of the dependency component. Fixes nix-community#488, though it seems this was changed intentionally by @tinybeachthor in nix-community#311 (specifically 156d7e0), so this might break something else?

tinybeachthor added 30 commits September 27, 2022 12:51

php: packagist platform to indexers/libraries-io

d2c0d1b

fix: libraries-io skip packages without versions

4b9538f

php: add packagist translator

26a0088

fix: php: composer-lock path source

a9d1f07

fix: php: packagist translator set version

f49af63

Set version in `composer.json` to the package version, composer is conservative and will fail if there the package version is not set and any dependency version conflicts are declared.

php: composer-json ignore platform reqs & scripts

685efe7

fix: php: handle deps without composer.json

2a4dd11

Without composer.json in the root of a package, composer will ignore the dependency, this is issue if for example npm dependencies are managed via composer. (yiisoft/yii2 2.0.46)

php: semver stabilities, wildcard

782a955

fix: php: add require default {}

056ef41

php: cleanup translators

7a2ff69

php: builders passAsFile repositories,dependencies

4f8e284

php: composer-json override .config.lock=false

8c8cde2

php: semver handle 4 digits (1.2.3.4)

7738907

fix: php: composer-lock use dist path sources

12791f0

fix: php: pass composer-plugin-api to composer-plugins

f1888d4

fix: php: package names ensure lowercase

2f499eb

fix: php: invalid authors + overrides

cac7782

php: set rootName & rootVersion for path sources

156d7e0

fix: php: handle deps without composer.json

44a7795

Without composer.json in the root of a package, composer will ignore the dependency, this is issue if for example npm dependencies are managed via composer. (yiisoft/yii2 2.0.46)

php: semver stabilities, wildcard, 4 part versions

89c1de4

fix: php: invalid authors + overrides

c2c61b8

fix: php: set package name

c523f2c

package name and composer.json#name can be different (mostly happens in private repositories) set the composer.json#name to the package name before including the package in other one

php: disable patches

039886b

no network access in the pure builder, patches will have to be handled as overrides probably

Allow disabling submodules for git fetcher

5363f36

php: do not pull git submodules

a7ca274

when composer is installing from source it ignores git submodules, do the same

php: split build into phases (easier to override)

6181050

php: add overrides

50f7682

php: install dependencies with --no-dev

ff264cb

Add replaceRootSources app

3a073e4

Use replaceRootSources (was callNixWithD2N)

54a89da

tinybeachthor added 5 commits September 28, 2022 13:19

Fix spelling

8e9fbc4

nodejs: discoverer read files from tree

a8b1461

defaultPackage -> packages.default

ae7454e

fix: pure translator template, project is not list

ec82af4

{utils -> lib.strings}.sanitizeDerivationName

1eea903

tinybeachthor closed this Oct 1, 2022

DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022

raboof mentioned this pull request Mar 18, 2023

PHP: don't set rootName for dist type path #495

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor cleanup #311

Minor cleanup #311

tinybeachthor commented Sep 30, 2022 •

edited

Loading

Minor cleanup #311

Minor cleanup #311

Conversation

tinybeachthor commented Sep 30, 2022 • edited Loading

tinybeachthor commented Sep 30, 2022 •

edited

Loading