targets.genericLinux: include additional directories in XCURSOR_PATH #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berbiche
reviewed
Apr 19, 2022
modules/targets/generic-linux.nix
Outdated
| # https://github.com/nix-community/home-manager/pull/2891#issuecomment-1101064521 | ||
| home.sessionVariables = { | ||
| XCURSOR_PATH = concatStringsSep ":" [ | ||
| "\${XCURSOR_PATH}" |
There was a problem hiding this comment.
I think we need to use sessionVariablesExtra if we want to extend an environment variable.
I am wrong.
berbiche
reviewed
Apr 19, 2022
modules/targets/generic-linux.nix
Outdated
Comment on lines
50
to
51
| XCURSOR_PATH = concatStringsSep ":" [ | ||
| "\${XCURSOR_PATH}" |
There was a problem hiding this comment.
Suggested change
| XCURSOR_PATH = concatStringsSep ":" [ | |
| "\${XCURSOR_PATH}" | |
| XCURSOR_PATH = | |
| "$XCURSOR_PATH\${XCURSOR_PATH:+:}" | |
| + concatStringsSep ":" [ |
This will need to be formatted.
There was a problem hiding this comment.
I forgot to consider the case where XCURSOR_PATH is null and/or unset. Thanks!
This commit appends system-wide icon and pixmap directory and the icon directory in the home-manager profile to the XCURSOR_PATH session variable for the generic linux target. This is necessary because the default prefix for libXcursor resolves to the Nix store which excludes the aforementioned directories from being searched for cursor themes. [1] [1] - #2891 (comment).
berbiche
approved these changes
Apr 20, 2022
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Apr 28, 2022
…ix-community#2902) This commit appends system-wide icon and pixmap directory and the icon directory in the home-manager profile to the XCURSOR_PATH session variable for the generic linux target. This is necessary because the default prefix for libXcursor resolves to the Nix store which excludes the aforementioned directories from being searched for cursor themes. [1] [1] - nix-community#2891 (comment).
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
…ix-community#2902) This commit appends system-wide icon and pixmap directory and the icon directory in the home-manager profile to the XCURSOR_PATH session variable for the generic linux target. This is necessary because the default prefix for libXcursor resolves to the Nix store which excludes the aforementioned directories from being searched for cursor themes. [1] [1] - nix-community#2891 (comment).
This was referenced Jan 2, 2023
bug: error: The option `home.sessionVariables.XCURSOR_PATH' has conflicting definition values:
#3551
Closed
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
…ix-community#2902) This commit appends system-wide icon and pixmap directory and the icon directory in the home-manager profile to the XCURSOR_PATH session variable for the generic linux target. This is necessary because the default prefix for libXcursor resolves to the Nix store which excludes the aforementioned directories from being searched for cursor themes. [1] [1] - nix-community#2891 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit appends system-wide icon and pixmap directory and the icon
directory in the home-manager profile to the XCURSOR_PATH session variable
for the generic linux target. This is necessary because the default prefix
for libXcursor resolves to the Nix store which excludes the aforementioned
directories from being searched for cursor themes. [1]
[1] - #2891 (comment).
Description
cc: @EHfive
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.