Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-manager: import modules relative to the location #472

Conversation

kalbasit
Copy link
Collaborator

@kalbasit kalbasit commented Dec 2, 2018

I pin the home-manager in my configuration and there's no home-manager channel available, this PR removes the dependency on the channel.

@kalbasit kalbasit force-pushed the home-manager_import-relative-only branch from ba1551b to f84e886 Compare December 2, 2018 08:18
@rycee
Copy link
Member

rycee commented Dec 2, 2018

Hmm, won't this be problematic for people pulling Home Manager directly from the online tarball? I.e., having something like

programs.home-manager.path = https://github.com/rycee/home-manager/archive/master.tar.gz

in their configuration. Seems to me that the import ../modules would then refer to the modules of the running Home Manager, not the most recently downloaded one.

@kalbasit
Copy link
Collaborator Author

kalbasit commented Dec 3, 2018

That's interesting. I've always thought the first home-manager you install goes away in favor of the one in programs.home-manager.path per the implementation: https://github.com/rycee/home-manager/blob/ef29f321e071cc4ebea35560ef93aec66a1032f2/modules/programs/home-manager.nix#L36-L41

I think the right step is to unify them in one and your work on #475 is a step forward in the right direction.

What should we do with this PR though? It caught me off guard that it referenced a channel when you expect a source to be self-contained.

@rycee
Copy link
Member

rycee commented Dec 3, 2018

Sorry, I had a closer look and I believe this change is safe. The ../modules should still refer to the newly downloaded modules even though it doesn't go the detour through <home-manager>.

@rycee
Copy link
Member

rycee commented Dec 3, 2018

Rebased to master in 30f3baa. Thanks!

@rycee rycee closed this Dec 3, 2018
@kalbasit kalbasit deleted the home-manager_import-relative-only branch January 29, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants