-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/nixos: add disko-zfs-swap #1252
base: master
Are you sure you want to change the base?
Conversation
Should I test installing this on build01? |
No, I'll do it myself. I would appreciate a response to #1207 (comment). |
Without trying it myself, I can't tell. |
a2310a7
to
32f118f
Compare
@Mic92 I tried this on build01. Installed, booted, another zfs import error. Is there some sort of weird systemd-boot / zfs problem? |
No. I use systemd-boot in many places. Only thing I can think of is that the pool is not exported correctly. In nixos-anywhere we do this: https://github.com/nix-community/nixos-anywhere/blob/f99d120b3788a286989db4e592a698f5d310d2f6/src/nixos-anywhere.sh#L516 |
I disabled uefi on build03 so now it is the same as 01 and 02. |
mountpoint = "/"; | ||
options.mountpoint = "legacy"; | ||
}; | ||
writeback = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannot create 'zroot/writeback': out of space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a new installation or incremental one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New.
Disko installTest log is here: https://buildbot.nix-community.org/#/builders/3544/builds/1/steps/1/logs/stdio.
# Sometimes fails after the first try, with duplicate pool name errors | ||
boot.initrd.systemd.services.zfs-import-zroot.serviceConfig.Restart = "on-failure"; | ||
|
||
zramSwap.writebackDevice = "/dev/zvol/zroot/writeback"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this suffer from the same issue that we also have with swap files on zfs filesystems? Also now that zfs has proper direct I/O maybe this is not an issue? https://github.com/openzfs/zfs/releases/tag/zfs-2.3.0-rc1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zvol is used as an example in the zram-generator docs so I'm assuming that it works.
No description provided.