Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/nixos: add disko-zfs-swap #1252

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

modules/nixos: add disko-zfs-swap #1252

wants to merge 4 commits into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 2, 2024

No description provided.

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2024

Should I test installing this on build01?

@zowoq
Copy link
Contributor Author

zowoq commented Jun 8, 2024

Should I test installing this on build01?

No, I'll do it myself.

I would appreciate a response to #1207 (comment).

@Mic92
Copy link
Member

Mic92 commented Jun 10, 2024

Should I test installing this on build01?

No, I'll do it myself.

I would appreciate a response to #1207 (comment).

Without trying it myself, I can't tell.

@zowoq
Copy link
Contributor Author

zowoq commented Jul 5, 2024

@Mic92 I tried this on build01. Installed, booted, another zfs import error. Is there some sort of weird systemd-boot / zfs problem?

@Mic92
Copy link
Member

Mic92 commented Jul 5, 2024

@Mic92 I tried this on build01. Installed, booted, another zfs import error. Is there some sort of weird systemd-boot / zfs problem?

No. I use systemd-boot in many places. Only thing I can think of is that the pool is not exported correctly. In nixos-anywhere we do this: https://github.com/nix-community/nixos-anywhere/blob/f99d120b3788a286989db4e592a698f5d310d2f6/src/nixos-anywhere.sh#L516

@zowoq
Copy link
Contributor Author

zowoq commented Jul 6, 2024

I disabled uefi on build03 so now it is the same as 01 and 02.

mountpoint = "/";
options.mountpoint = "legacy";
};
writeback = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot create 'zroot/writeback': out of space

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a new installation or incremental one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Sometimes fails after the first try, with duplicate pool name errors
boot.initrd.systemd.services.zfs-import-zroot.serviceConfig.Restart = "on-failure";

zramSwap.writebackDevice = "/dev/zvol/zroot/writeback";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this suffer from the same issue that we also have with swap files on zfs filesystems? Also now that zfs has proper direct I/O maybe this is not an issue? https://github.com/openzfs/zfs/releases/tag/zfs-2.3.0-rc1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants