refact(ops/stream_events): directly construct json value #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
force-pushed
the
stream-events-json-macro
branch
2 times, most recently
from
1d7fff3
to
3725799
Compare
Instead of having complex generic types internally that we map over, just create the json in a macro. Removes `ProjectAdded` from `Reason`, because it was not used anywhere. Changes the daemon format, so make sure to run the daemon with this new lorri version or you get serialization errors.
Profpatsch
force-pushed
the
stream-events-json-macro
branch
from
3725799
to
965ae90
Compare
|
@nyarly you are using stream_events right? Do you wanna try this out, in case I added a typo somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having complex generic types internally that we map over, just create the json in a macro.
Removes
ProjectAddedfromReason, because it was not used anywhere. Changes the daemon format, so make sure to run the daemon with this new lorri version or you get serialization errors.release.nix(seerelease.nixfor instructions)