Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend XDG_{CONFIG,DATA}_DIRS #61

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Aug 3, 2021

Closes #2, Closes #48

Bash completions for home-manager broke in directories where lorri is used because XDG_DATA_DIRS got overwritten. I decided we should prepend it instead. I also searched home-manager for similar envs and found another one which I think we should prepend by default.

  • Amended the changelog in release.nix (see release.nix for instructions)

@roberth
Copy link
Contributor

roberth commented Aug 21, 2021

Also closes #2; might want to add that to the description.

@neumantm
Copy link

I would really like this fix.
@SuperSandro2000 are you still planning to add the changelog to release.nix?

@SuperSandro2000
Copy link
Member Author

No, I leave that up to @Profpatsch. The version number makes random jumps and I have no clue what the next number should be.

@Profpatsch
Copy link
Collaborator

Thanks, I missed this PR, looks good to me.

@Profpatsch Profpatsch merged commit 8e9ff58 into nix-community:canon Jan 13, 2022
@SuperSandro2000 SuperSandro2000 deleted the fix_XDG_DATA_DIRS branch January 13, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lorri direnv reset XDG_DATA_DIRS. Shell completions, possible approaches
4 participants